-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rapidast on rhwa FAR operator #310
base: main
Are you sure you want to change the base?
Rapidast on rhwa FAR operator #310
Conversation
1cdce82
to
a7ce030
Compare
@clobrano please review. |
fdd4ca1
to
ece4d24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test looks fine but curious why you are removing the Dockerfile?
ece4d24
to
c850fb0
Compare
it is already merged in #320 |
c850fb0
to
9823cdd
Compare
9823cdd
to
45c39b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall is a good PR. I added few comments.
7df791b
to
bd8f301
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The dast test for far operator is moved to a separate file, and it is labeled with additional "dast" label, to be able to run it apart from the rest of the operator tests if needed.
f3ae0d7
to
8ddd3ec
Compare
This test runs a container to run rapidast utility from inside the cluster, running inside the trivy scanner that checks for vulnerabilities in running pods of the configured namespace.
The test fails in case there is a vulnerability found.