Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rapidast on rhwa FAR operator #310

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

frajamomo
Copy link
Contributor

This test runs a container to run rapidast utility from inside the cluster, running inside the trivy scanner that checks for vulnerabilities in running pods of the configured namespace.
The test fails in case there is a vulnerability found.

@frajamomo frajamomo force-pushed the rapidast_on_rhwa_operators branch 9 times, most recently from 1cdce82 to a7ce030 Compare December 3, 2024 14:14
@frajamomo
Copy link
Contributor Author

@clobrano please review.

@frajamomo frajamomo force-pushed the rapidast_on_rhwa_operators branch 2 times, most recently from fdd4ca1 to ece4d24 Compare December 9, 2024 08:08
@frajamomo
Copy link
Contributor Author

@kononovn @trewest please review.

Copy link
Collaborator

@trewest trewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks fine but curious why you are removing the Dockerfile?

@frajamomo frajamomo force-pushed the rapidast_on_rhwa_operators branch from ece4d24 to c850fb0 Compare December 16, 2024 07:07
@frajamomo
Copy link
Contributor Author

Test looks fine but curious why you are removing the Dockerfile?

it is already merged in #320

@frajamomo frajamomo force-pushed the rapidast_on_rhwa_operators branch from c850fb0 to 9823cdd Compare December 23, 2024 08:24
@frajamomo frajamomo force-pushed the rapidast_on_rhwa_operators branch from 9823cdd to 45c39b3 Compare January 16, 2025 08:23
Copy link

@clobrano clobrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall is a good PR. I added few comments.

tests/rhwa/internal/rapidast/rapidast.go Outdated Show resolved Hide resolved
tests/rhwa/internal/rapidast/rapidast.go Outdated Show resolved Hide resolved
tests/rhwa/internal/rapidast/rapidast.go Outdated Show resolved Hide resolved
tests/rhwa/internal/rhwaparams/const.go Show resolved Hide resolved
@frajamomo frajamomo force-pushed the rapidast_on_rhwa_operators branch 2 times, most recently from 7df791b to bd8f301 Compare January 27, 2025 07:59
Copy link
Collaborator

@trewest trewest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

The dast test for far operator is moved to a separate file, and it
is labeled with additional "dast" label, to be able to run it apart
from the rest of the operator tests if needed.
@frajamomo frajamomo force-pushed the rapidast_on_rhwa_operators branch from f3ae0d7 to 8ddd3ec Compare January 29, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants